![]() ![]() The pull request was nevertheless merged. All of which github entirely screws up."ĭon't do this: A merge using the GitHub user interface But it also means proper authorship and committer information etc. Torvalds said that "Linux kernel merges need to be done *properly*." He added: "That means proper commit messages with information about what is being merged and *why* you merge something. Third, Paragon's repository has commit messages which lack information, like "Merge branch 'torvalds:master' into master." The ensuing forthright thread has more information on the subject. Note that the git request-pull command is different from the GitHub pull request feature. The diffstat is also deficient and useless." github throws away all the relevant information, like having even a valid email address for the person asking me to pull. Torvalds has complained about aspects of GitHub before, saying in 2012: "I don't do github pull requests. He added: "ithub is a perfectly fine hosting site, and it does a number of other things well too, but merges is not one of those things." ![]() "That's another of those things that I *really* don't want to see github creates absolutely useless garbage merges, and you should never ever use the github interfaces to merge anything," he said. Second, he noted that the code in the pull request included merge commits done with the GitHub web user interface. "In a perfect world, it would be a PGP signature that I can trace directly to you through the chain of trust, but I've never actually required that," he said. However, the company is still getting to grips with the submission process and Torvalds had several comments to make, intended to improve future pull requests.įirst, he said the pull request should have been signed. On Friday Paragon duly submitted its pull request, saying: "Current version works with normal/compressed/sparse files and supports acl, NTFS journal replaying." NTFS is the native Windows file system and Paragon's implementation will improve interoperability, versus the existing driver which has limited write support. "Hopefully this will mean that I get fewer pull requests that have new warnings that were not noticed by various automation we have in place… Knock wood," he said.Linus Torvalds will pull Paragon Software's NTFS driver into the 5.15 kernel source but he complained about the use of a GitHub merge in the submission, saying that GitHub "creates absolutely useless garbage merges."Įarly last month Torvalds gave Paragon Software a nudge that it really should submit a pull request an actual submission of code to be merged into the kernel source in order for its read-write NTFS driver to be included in the forthcoming 5.15 release, for which the merge window is currently open. Torvalds added that "we… will disable specific over-eager warnings as required, if we can't fix them." ![]() The meaning of -Werror is "Make all warnings into errors," requiring stricter discipline for code that would otherwise compile but with warnings about suboptimal code. 30 years of Linux: OS was successful because of how it was licensed, says Red HatĪn example of a well-commented change came from Torvalds yesterday, when he amended the Makefile used for compiling the kernel to "enable '-Werror' by default for all kernel builds … but make it a config option so that broken environments can disable it when required.".'Apps for GNOME' site aims to improve discovery of the project's best applications.When you finish celebrating Linux turning 30, try new Linux 5.14, says Linus Torvalds.Tachyum's Prodigy emulator achieves first boot, runs Linux and says 'hello, world'. ![]() "The initial pull often has a few oddities and I'll accept them now, but for continued development you need to do things properly," said Torvalds. Don't do this: A merge using the GitHub user interface ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |